feat(datafusion): Implement IcebergWriteExec for DataFusion write support #1585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @CTTY for this pr, in generally look good! Just one minor nit.
| } | ||
|
|
||
| impl IcebergWriteExec { | ||
| pub fn new(table: Table, input: Arc<dyn ExecutionPlan>, schema: ArrowSchemaRef) -> Self { |
There was a problem hiding this comment.
Another point is that we should ensure that the input schema matches table's schema, otherwise we are doing schema evolution during write.
There was a problem hiding this comment.
Columns nullability and field type would be checked within execute_input_stream when it's binding the Iceberg table schema to the input RecordBatch. So we don't need to worry about it now.
This may prevent us from doing any forms of schema evolution, but I think that's a separate issue
liurenjie1024
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
IcebergWriteExecto write the input execution plan to parquet files, and returns serialized data filesAre these changes tested?
added ut